fix(workers): prevent uvloop from setting global event loop policy in healthcheck #19660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… healthcheck uvicorn ≤0.35.0 with uvloop installed sets a global uvloop.EventLoopPolicy() when starting, which breaks subprocess spawning when a SelectorEventLoop is used (uvloop's policy doesn't implement get_child_watcher()). This adds loop="asyncio" to the healthcheck uvicorn config to prevent this, and updates settings access to use the new get_current_settings() pattern. Fixes #19658 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
CodSpeed Performance ReportMerging #19660 will not alter performanceComparing Summary
|
cicdw
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
uvloopis installed (viauvicorn[standard])loop="asyncio"to uvicorn config to prevent uvloop from setting a global event loop policyget_current_settings()patternRoot cause
uvicorn ≤0.35.0 with uvloop installed calls
uvloop_setup()which sets a globaluvloop.EventLoopPolicy(). When the worker then tries to spawn a subprocess using aSelectorEventLoop, it fails because uvloop's policy doesn't implementget_child_watcher().Test plan
--with-healthcheckFixes #19658
🤖 Generated with Claude Code