fix(fns): handle BinaryImage/UserContent types as attachments in extract() and classify()#1340
Open
octo-patch wants to merge 1 commit into
Conversation
…act() and classify() When passing pydantic-ai UserContent types (BinaryImage, ImageUrl, AudioUrl, etc.) to marvin.extract() or marvin.classify(), the binary data was serialized into the task context as a string, causing token explosion (200K+ tokens for moderately-sized images). This is the same issue as PrefectHQ#1246 which was already fixed for cast(). Fixes the same class of bug in extract() and classify() by detecting UserContent attachment types and passing them as task attachments instead of context values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the UserContent attachment handling (similar to #1257 for
cast()) toextract()andclassify().Problem
When passing pydantic-ai
UserContenttypes (BinaryImage,ImageUrl,AudioUrl,DocumentUrl,VideoUrl) tomarvin.extract()ormarvin.classify(), the binary data is serialized into the task context as a string, causing token explosion (200K+ tokens for moderately-sized images).Example that fails with token explosion:
Solution
Added detection for pydantic-ai's
UserContenttypes inextract()andclassify()— the same fix applied tocast()in #1257. Binary/URL content types are now passed as task attachments instead of being serialized into the context dictionary.Testing
extract()withBinaryImageandImageUrlinputsclassify()withBinaryImageandImageUrlinputs