Fix pydantic-ai deprecation warning: mcp_servers -> toolsets#1206
Merged
Conversation
Updates the pydantic-ai Agent instantiation to use the new 'toolsets' parameter instead of the deprecated 'mcp_servers' parameter. This change is internal only - Marvin's public API remains unchanged. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a deprecation warning from pydantic-ai by updating the parameter name used internally when passing MCP servers to pydantic-ai's Agent constructor.
- Updates internal parameter from
mcp_serverstotoolsetsto align with pydantic-ai's current API - Maintains full backwards compatibility for Marvin's public API
- Eliminates deprecation warning in test suite
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the deprecation warning from pydantic-ai by updating the parameter name from
mcp_serverstotoolsetswhen instantiating pydantic-ai's Agent.Closes #1205
Problem
The test suite was showing this deprecation warning:
Solution
Updated the single location where Marvin passes MCP servers to pydantic-ai's Agent constructor:
agent_kwargs["mcp_servers"]toagent_kwargs["toolsets"]insrc/marvin/agents/agent.py:209This is an internal implementation detail only. Marvin's public API remains unchanged - users continue to use
mcp_serverswhen creating Marvin Agents.Testing
✅ Verified the deprecation warning exists on main branch
✅ Confirmed the warning is eliminated with this fix
✅ All MCP-related tests pass:
tests/ai/test_mcp.pytests/agents/test_mcp_integration.pyBackwards Compatibility
This change maintains full backwards compatibility:
mcp_serversto Marvin's Agent class🤖 Generated with Claude Code