Changes post recovery of failed drive#464
Open
eliotmcintire wants to merge 46 commits intodevelopmentfrom
Open
Changes post recovery of failed drive#464eliotmcintire wants to merge 46 commits intodevelopmentfrom
eliotmcintire wants to merge 46 commits intodevelopmentfrom
Conversation
…s into a module it appears totally different
Installs reproducible from the current branch, then runs rcmdcheck on SpaDES.core to catch any breaking changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…not relevant for digest
1. showCacheEtc.R: pass `x` to collect_showCache_async()
`collect_showCache_async(wait = TRUE)` was called without `x`, so it
defaulted to getOption("reproducible.cachePath"). When that option holds a
length-2 vector (test-multipleCacheRepo sets it to c(tmpdir, tmpCache)),
.pkgEnv[[cachePath]] fails with "wrong arguments for subsetting an
environment". Fix: pass `x` explicitly so the correct per-path memoiseEnv
is used.
2. GPT2.R: devMode must only clear entries whose userTags match
showSimilar() ran showCache() filtered by userTags but immediately
overwrote shownCache with an unfiltered call. The devMode clearing at
line 1103 then used simi (derived from ALL function matches), replacing
cache entries that had no matching userTags. Fix: save the
userTags-filtered result as shownCacheUserTags and intersect
cacheIdsToClear with its cacheIds before clearing.
3. test-cacheGeo.R: update expected message for first iteration
Commit 06a409b added a distinct "No remote targetFile exists" message
for when objExisted is FALSE. The test expected "Domain is not contained"
for zoneA (first run, file not yet created). Fix: expect the correct
"No remote targetFile" message for iter 1.
4. test-cacheHelpers.R: fix wrong expectation at line 182
The test expected "no similar item" for Cache(rnorm,1,3,4,userTags="By")
when cache already held Cache(rnorm,1,2,3,userTags="Hi"). showSimilar
correctly finds the entry as similar (3 differences). The comment
"shouldn't find b/c args are same" was wrong — args differ. Fix: expect
that similar IS found (expect_false instead of expect_true).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove test "test failed Cache recovery -- message to delete cacheId": DBI + non-V3 (useCacheV3=FALSE) is not supported; optionsSetForCache() always forces useCacheV3=TRUE on every Cache() call, making this configuration unreachable - setup.R: preserve runLargeFileTests if already TRUE (isTRUE check) - setup.R: preserve useCacheV3=FALSE if explicitly set (!isFALSE check) so developers can run DBI-specific tests without setup.R overriding Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add @param entries for cacheId, cachePath, drv, conn, verbose which were present in the function signature but missing from roxygen docs, causing R CMD check WARNING. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
parallel::mccollect() is fork-based and not available on Windows. The .onLoad call already had !isWindows() guard; apply same to .onUnload to prevent R CMD check WARNING on Windows devel. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pak does not install Suggests by default, so knitr (VignetteBuilder in SpaDES.core) was missing, causing rcmdcheck to fail with "vignette builder 'knitr' not found". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- test-downstream: add dependencies=TRUE so SpaDES.core/SpaDES.project Suggests (testthat, DBI, RSQLite, etc.) are installed before rcmdcheck - R-CMD-check: remove pak-version: devel which caused 'pak not found' in Repo status step on Windows R-devel Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ution NLMR (>= 1.1.1) is in SpaDES.core's Suggests but not on CRAN. With dependencies=TRUE, pak fails at resolution stage because it cannot find NLMR. Installing ropensci/NLMR first lets pak find it in the local library and proceed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…elease setLinuxBinaryRepo() in CRAN Require uses bare `if (insertBefore > 1)` which errors with argument-of-length-zero when no CRAN repo is found; the fix (isTRUE wrapper) is on Require@development. Remove this step once the fix is released to CRAN. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…: Cannot open lock file: Too many open files
The main branch has pre-existing issues (mockery undeclared, experiment3 example fails without global.R). These are fixed on development. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.