LSP services fail with non-ASCII characters in paths

[Ebola-Chan-bot]

Under PS5.1 mode, typing "Get-" triggers a list of commands starting with that.

However, with PS7.0, nothing happens:

What's wrong here?

[SydneyhSmith]

@silver-fang thanks for opening this issue and providing screenshots. I am having some trouble reproducing this issue but the issue may be do to performance issues we sometimes see in the PowerShell extension i.e. the completions are so slow that it appears they are not coming at all...I would be curious to see if you are able to reproduce this in the PowerShell Preview extension? We recently merged 6+months of stability/performance improvements into preview, and are hoping to ship those in our "stable" PowerShell extension in January. It would also be good to know if you are able to get any other features of the extension working with PS7 i.e. are you able to run code using F8 in the integrated terminal...if not or you are hitting other errors/failures logs would be very helpful...thanks!

[rjmholt]

@silver-fang you should be getting completions in PS 7 the same as you see with PS 5.1; what you're seeing looks like a bug.

If you're able to attach your logs here, we might be able to determine the cause of the issue.

[Ebola-Chan-bot]

logs.zip
I'm well ready reproducing it in the preview extension

[rjmholt]

Seeing this in one of the logs:

2019-12-07 11:26:46.041 +08:00 [FTL] Failed to handle notification textDocument/documentSymbol
System.UriFormatException: Invalid URI: The hostname could not be parsed.
   at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   at System.Uri..ctor(String uriString)
   at Microsoft.PowerShell.EditorServices.Services.WorkspaceService.ResolveFilePath(String filePath) in D:\a\1\s\src\PowerShellEditorServices\Services\Workspace\WorkspaceService.cs:line 438
   at Microsoft.PowerShell.EditorServices.Services.WorkspaceService.GetFile(String filePath) in D:\a\1\s\src\PowerShellEditorServices\Services\Workspace\WorkspaceService.cs:line 144
   at Microsoft.PowerShell.EditorServices.Handlers.DocumentSymbolHandler.Handle(DocumentSymbolParams request, CancellationToken cancellationToken) in D:\a\1\s\src\PowerShellEditorServices\Services\TextDocument\Handlers\DocumentSymbolHandler.cs:line 63
   at MediatR.Internal.RequestHandlerWrapperImpl`2.<>c__DisplayClass0_0.<Handle>g__Handler|0()
   at OmniSharp.Extensions.LanguageServer.Server.Pipelines.ResolveCommandPipeline`2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate`1 next)
   at MediatR.Pipeline.RequestPostProcessorBehavior`2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate`1 next)
   at MediatR.Pipeline.RequestPreProcessorBehavior`2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate`1 next)
   at OmniSharp.Extensions.JsonRpc.RequestRouterBase`1.RouteRequest(TDescriptor descriptor, Request request, CancellationToken token)

[rjmholt]

And here:

2019-12-07 11:26:59.825 +08:00 [FTL] Failed to handle notification textDocument/completion
System.UriFormatException: Invalid URI: The hostname could not be parsed.
   at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   at System.Uri..ctor(String uriString)
   at Microsoft.PowerShell.EditorServices.Services.WorkspaceService.ResolveFilePath(String filePath) in D:\a\1\s\src\PowerShellEditorServices\Services\Workspace\WorkspaceService.cs:line 438
   at Microsoft.PowerShell.EditorServices.Services.WorkspaceService.GetFile(String filePath) in D:\a\1\s\src\PowerShellEditorServices\Services\Workspace\WorkspaceService.cs:line 144
   at Microsoft.PowerShell.EditorServices.Handlers.CompletionHandler.Handle(CompletionParams request, CancellationToken cancellationToken) in D:\a\1\s\src\PowerShellEditorServices\Services\TextDocument\Handlers\CompletionHandler.cs:line 68
   at OmniSharp.Extensions.LanguageServer.Server.Pipelines.ResolveCommandPipeline`2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate`1 next)
   at MediatR.Pipeline.RequestPostProcessorBehavior`2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate`1 next)
   at MediatR.Pipeline.RequestPreProcessorBehavior`2.Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate`1 next)
   at OmniSharp.Extensions.JsonRpc.RequestRouterBase`1.RouteRequest(TDescriptor descriptor, Request request, CancellationToken token)

That explains the lack of completions

[rjmholt]

Would you be able to provide the path of the file you're trying to complete in?

Alternatively, if you can provide the payload logs, that will show the contents of the LSP messages PSES is being sent causing it to crash.