Skip to content

Handle arbitrary exceptions when recursing workspace #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Handle arbitrary exceptions when recursing workspace #862

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10c7084
Handle arbitrary exceptions when recursing workspace
rjmholt Jan 23, 2019
46ff095
Jump out of golden path on exceptions
rjmholt Jan 23, 2019
fdd0d73
Blank lines
rjmholt Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/PowerShellEditorServices/Workspace/Workspace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,14 @@ private void RecursivelyEnumerateFiles(string folderPath, ref List<string> found

continue;
}
catch (Exception e)
{
this.logger.WriteHandledException(
$"Could not enumerate files in the path '{folderPath}' due to an exception",
e);

continue;
}

foundFiles.AddRange(psFiles);
}
Expand Down Expand Up @@ -386,6 +394,15 @@ private void RecursivelyEnumerateFiles(string folderPath, ref List<string> found

return;
}
catch (Exception e)
{
this.logger.WriteHandledException(
$"Could not enumerate directories in the path '{folderPath}' due to an exception",
e);

return;
}


foreach (string subDir in subDirs)
{
Expand Down