Skip to content

Fix a bug where avoidusernameandpasswordparam is too noisy #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2016

Conversation

quoctruong
Copy link

Don't raise the rule if the password is a securestring, pscredentialtype or pscredential

Review on Reviewable

@raghushantha
Copy link
Member

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


Rules/AvoidUserNameAndPasswordParams.cs, line 64 [r1] (raw file):
Quoc - Can you add a comment here explaining the checks done and the order in which they are done?


Comments from the review on Reviewable.io

@raghushantha
Copy link
Member

:lgtm:


Comments from the review on Reviewable.io

@raghushantha
Copy link
Member

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

quoctruong pushed a commit that referenced this pull request Feb 8, 2016
Fix a bug where avoidusernameandpasswordparam is too noisy
@quoctruong quoctruong merged commit ace23a9 into development Feb 8, 2016
@quoctruong quoctruong deleted the FixAvoidUserNameAndPasswordParam branch February 8, 2016 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants