Skip to content

UseCorrectCasing: Do not correct applications or script paths at all #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2019
Merged

UseCorrectCasing: Do not correct applications or script paths at all #1255

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c891b6
UseCorrectCasing: Preserve script paths
bergmeister Jun 6, 2019
3770023
make test ps v4 compatible (new-guid cmdlet does not exists on v4)
bergmeister Jun 6, 2019
c8feb9c
Add test case for general paths
bergmeister Jun 6, 2019
069d02f
Add test case for application paths as discussed and do not correct a…
bergmeister Jun 6, 2019
9320a74
Use environment variable to get Windows directory to address PR feedback
bergmeister Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Rules/UseCorrectCasing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file
}

var commandInfo = Helper.Instance.GetCommandInfo(commandName);
if (commandInfo == null)
if (commandInfo == null || commandInfo.CommandType == CommandTypes.ExternalScript)
{
continue;
}
Expand Down
7 changes: 7 additions & 0 deletions Tests/Rules/UseCorrectCasing.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,11 @@ Describe "UseCorrectCasing" {
}
Invoke-Formatter 'invoke-dummyFunction' | Should -Be 'Invoke-DummyFunction'
}

It "preserves script paths" -Skip:($IsLinux -or $IsMacOS) {
$uncPath = [System.IO.Path]::Combine("\\$(HOSTNAME.EXE)\C$\", $TestDrive, "$([guid]::NewGuid()).ps1")
New-Item -ItemType File -Path $uncPath
$scriptDefinition = ". $uncPath"
Invoke-Formatter $scriptDefinition | Should -Be $scriptDefinition
}
}