AvoidPositionalParametersNoViolations.ps1 lacks an Space

[Kriegel]

Hi !

Currently i am developing an PowerShell prettifier / beautifier / refactoring Module
For this I am using the Rule Testing Files out of this Module.

So I am found a little Typo in the File named:
AvoidPositionalParametersNoViolations.ps1

https://github.com/PowerShell/PSScriptAnalyzer/blob/master/Tests/Rules/AvoidPositionalParametersNoViolations.ps1

The Typo is on line 6

get-service-computername localhost | where {($_.status -eq "Running") -and ($_.CanStop -eq $true)}

a space between get-service and -computername is missing.

Hope this helps.

My PowerShell prettifier / beautifier / refactoring Module is developed here:
Kriegel/BeautyOfPower

[rjmholt]

Hope this helps.

If you feel like opening a PR, that would be even more helpful

[Kriegel]

Hi @rjmholt Robert

I guess PR means Pull Request !? ??

Shame on me, even if I am developing on Github, I never used Pull Request, so I do not know the how to ...

In my further development I found, that ' Get-Service' has no '-ComputerName' Parameter on PS 6+7 anymore.
So line 6 is a deprecated candidate.

[Kriegel]

Hi @rjmholt Robert,

by the way ...
Do you really want that I fork a Repo and doing a Pull Request to correct a single Whitespace?
I think that is regulatory overkill.

Additionally, I think, that I am not the one who can decide if Line 6 is deprecated.

[SydneyhSmith]

Thanks @Kriegel for looking into this, totally understand where you are coming from about forking the repo but we try to keep our process in place as much as possible to set contributors up well for future pull requests, and to keep the repository in an easily maintainable state, that being said for a change like this you can also open the PR by creating a branch from the UI...No worries about not feeling like the right one to make the call around deprecation--that is the role of the maintainers to approve and manage those types of changes. I will go ahead and mark this as a bug and "Up for Grabs"--thanks

[rjmholt]

Do you really want that I fork a Repo and doing a Pull Request to correct a single Whitespace?

Indeed, you can do it all without leaving the browser:

I think that is regulatory overkill.

It's not a process thing, it's just the standard git workflow. We try not to create any excess process, and in this case there's no need for things like a tracking issue or discussion -- the code change, in the form of a PR, is sufficient.

[Kriegel]

@SydneyhSmith

Thank you all!
I have learned about online PRs and will do so in future.
Thank you for teaching me.
@rjmholt
I apologize if I sound to harsh, english is hard for me and is not my mother tounge.

Stay well!
Live long and prosper.