Fix regression in get-all default output #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgauth
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In the original change to support
json-arrayoutput, the conversion fromGetOutputFormattoOutputFormatdidn't correctly handleNonewhich ended up in the anything else default to JSON format whereasNoneshould return YAML when used interactively. The fix is to make sureNonegets propagated correctly.Also updated the
Processresource, which is only used for testing, to only emit 3 instances rather than having it scroll off the terminal.Finally, fixed a non-blocking test issue in the WinPS test that would fail on non-Windows during cleanup.
PR Context
Fix #866