-
Notifications
You must be signed in to change notification settings - Fork 47
Fix WinPS adapter tests #1017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix WinPS adapter tests #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c224749
to
c8b29cb
Compare
Closed
tgauth
reviewed
Jul 29, 2025
tgauth
approved these changes
Jul 29, 2025
382bdf1
to
902d073
Compare
$null
48ebf2d
to
db9530e
Compare
tgauth
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Pester 5.7.1 was crashing due to stdout leaking from
BeforeAll
. Fix is to redirect the native command output to$null
. In addition, modified test to be skipped if not Windows or not elevated. Removed nested use ofBeforeDiscovery
within tests.After resolving the crash, apparently many tests have been broken for some time but wasn't reported since Pester crashes before it writes the output file so CI thinks they all passed:
BeforeAll
section, isolate PATH and PSModulePath to use specific resources so that ones already on the system don't get usedPSCredential
instead of[PSCredential]
trap
in adapter so that any uncaught exceptions get traced[console]
is available before using as in CI it's not available