-
Notifications
You must be signed in to change notification settings - Fork 215
fix(surveys): react native text colors #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 5 comments
packages/react-native/src/surveys/components/QuestionHeader.tsx
Outdated
Show resolved
Hide resolved
lucasheriques
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment but looks good
packages/react-native/src/surveys/components/ConfirmationMessage.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: +1.41 kB (+0.03%) Total Size: 5.26 MB
ℹ️ View Unchanged
|

Problem
survey text color is hard-coded to black on react native. this means users can't create dark-mode surveys
Changes
inputBackgroundto core sdk types#111Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file