-
Notifications
You must be signed in to change notification settings - Fork 215
feat(product tours): add survey steps #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Size Change: +1.44 kB (+0.03%) Total Size: 5.19 MB
ℹ️ View Unchanged
|
06f88f1 to
8acb884
Compare
8acb884 to
07a7437
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 2 comments
lucasheriques
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor stuff and +1 on greptile comments too
| const step = this._activeTour.steps[this._currentStepIndex] | ||
|
|
||
| // Emit tour step shown event | ||
| this._captureEvent('product tour step shown', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thouse should be on an enum (future improvement)
packages/browser/src/extensions/product-tours/product-tours.tsx
Outdated
Show resolved
Hide resolved
07a7437 to
b810a9f
Compare

Problem
adds support for "survey"-type steps in product tours
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file