fix: include initial person props in $identify when group() called first #2725
+138
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip $set_once calculation for $groupidentify events since server strips person properties from them anyway. This prevents the flag from being set prematurely, ensuring UTM params are included with subsequent $identify.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Contributor
|
Size Change: +100 B (0%) Total Size: 5.19 MB
ℹ️ View Unchanged
|
Changed comma operator style to explicit return block in bootstrap featureFlags reduce. This resolves CI/local prettier formatting mismatch.
Member
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
Hmm, I unfortunately don't know enough about this, I'll defer to @robbie-c 's review
robbie-c
reviewed
Dec 11, 2025
- Remove _requirePersonProcessing from group() - groups work independently - Add markAsSent param to _calculate_set_once_properties() so $groupidentify events don't mark initial props as sent (server drops them anyway) - Still send props for future-proofing - worst case is duplicate processing, not missing data
robbie-c
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial person properties lost when
group()called beforeidentify()Bug
Calling
group()with properties beforeidentify()causes initial person properties (UTM params, referrer, etc.) to be lost from the person profile.Root cause:
group()triggers_calculate_set_once_properties()which marks initial person props as "sent" via_personProcessingSetOncePropertiesSent = true. Whenidentify()is called later, it skips sending these props because the flag is already set. However, the server ignores$set_onceon$groupidentifyevents, so the initial props are never actually saved.Fix
Skip
_calculate_set_once_properties()for$groupidentifyevents, since person properties don't apply to group events.Why it's safe
The server already strips
$set_oncefrom$groupidentifyevents (plugin-server/src/utils/event.ts:180-189):The SDK was sending person properties that the server discards anyway. This fix prevents the SDK from incorrectly marking them as "sent", ensuring they're included with the actual
$identifyevent where they belong.Impact
Affects customers using
person_profiles: 'identified_only'who callgroup()beforeidentify()a common B2B SaaS pattern where org context is set before user identification.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file