Skip to content

Conversation

@Gold856
Copy link
Collaborator

@Gold856 Gold856 commented Dec 7, 2025

Description

#2168 removed a v-if from the camera activation modal, which prevents the dialog from disappearing when cameras are activated on the backend with no other input from the user. That PR also misunderstood how to fix comparisons against the PlaceholderCameraSettings object. Because the object was reactive state due to it being in CameraSettingsStore, the comparison would always fail because it was comparing a reactive proxy to the original object, which never equals true. This uses the solution provided by the Vue docs, which is to wrap the whole object in reactive() so that accessing it is consistent.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner December 7, 2025 21:24
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Dec 7, 2025
@samfreund samfreund merged commit 1c802f5 into PhotonVision:main Dec 7, 2025
42 checks passed
@samfreund samfreund mentioned this pull request Dec 7, 2025
7 tasks
@Gold856 Gold856 deleted the fix-dashboard-view branch December 8, 2025 04:11
samfreund pushed a commit to samfreund/photonvision that referenced this pull request Dec 18, 2025
spacey-sooty pushed a commit to spacey-sooty/photonvision that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants