Test pipeline type when creating a new pipeline #2225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backend
mcm001
previously approved these changes
Dec 7, 2025
Contributor
mcm001
left a comment
mcm001
left a comment
There was a problem hiding this comment.
Let's add end to end tests in a follow on
github-actions
bot
added
the
frontend
samfreund
force-pushed
the
fix-pipeline-creation
branch
5 times, most recently
from
05d6f8a to
714d2dc
Compare
7 tasks
samfreund
changed the title
mcm001
pushed a commit
that referenced
this pull request
Dec 9, 2025
## Description <!-- What changed? Why? (the code + comments should speak for itself on the "how") --> <!-- Fun screenshots or a cool video or something are super helpful as well. If this touches platform-specific behavior, this is where test evidence should be collected. --> <!-- Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`. --> This cherry-picks the bug fix from #2225, but not the tests as we're having issues with those. #2225 will remain open for the tests. #2204 fixed the off-by-one error on the frontend, but again, because enums are serialized with ordinal(), DataSocketHandler needed to be updated to account for the indices shifting by one. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] ~If this PR addresses a bug, a regression test for it is added~ Deferred Co-authored-by: Gold856 <[email protected]>
Gold856
force-pushed
the
fix-pipeline-creation
branch
from
714d2dc to
75b2d25
Compare
samfreund
added a commit
to samfreund/photonvision
that referenced
this pull request
Dec 18, 2025
…onVision#2229) ## Description <!-- What changed? Why? (the code + comments should speak for itself on the "how") --> <!-- Fun screenshots or a cool video or something are super helpful as well. If this touches platform-specific behavior, this is where test evidence should be collected. --> <!-- Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`. --> This cherry-picks the bug fix from PhotonVision#2225, but not the tests as we're having issues with those. PhotonVision#2225 will remain open for the tests. PhotonVision#2204 fixed the off-by-one error on the frontend, but again, because enums are serialized with ordinal(), DataSocketHandler needed to be updated to account for the indices shifting by one. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] ~If this PR addresses a bug, a regression test for it is added~ Deferred Co-authored-by: Gold856 <[email protected]>
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
…onVision#2229) ## Description <!-- What changed? Why? (the code + comments should speak for itself on the "how") --> <!-- Fun screenshots or a cool video or something are super helpful as well. If this touches platform-specific behavior, this is where test evidence should be collected. --> <!-- Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`. --> This cherry-picks the bug fix from PhotonVision#2225, but not the tests as we're having issues with those. PhotonVision#2225 will remain open for the tests. PhotonVision#2204 fixed the off-by-one error on the frontend, but again, because enums are serialized with ordinal(), DataSocketHandler needed to be updated to account for the indices shifting by one. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] ~If this PR addresses a bug, a regression test for it is added~ Deferred Co-authored-by: Gold856 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2204 fixed the off-by-one error on the frontend, but again, because enums are serialized with ordinal(), DataSocketHandler needed to be updated to account for the indices shifting by one.
Meta
Merge checklist: