Remove PhotonJNICommon in favor of CombinedRuntimeLoader #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backend
samfreund
force-pushed
the
dang-it-matt
branch
from
4dcfadf to
8de5295
Compare
This was referenced Dec 7, 2025
Member
Author
|
Waiting on some PRs from other repos to convert to using the WPILib spec. |
This comment was marked as resolved.
This comment was marked as resolved.
samfreund
force-pushed
the
dang-it-matt
branch
2 times, most recently
from
16304bd to
dfe906e
Compare
samfreund
force-pushed
the
dang-it-matt
branch
from
b49d200 to
6865883
Compare
mcm001
previously approved these changes
Dec 7, 2025
samfreund
force-pushed
the
dang-it-matt
branch
2 times, most recently
from
97dd3be to
dfe2825
Compare
Gold856
requested changes
Dec 8, 2025
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Outdated
Show resolved
Hide resolved
samfreund
force-pushed
the
dang-it-matt
branch
2 times, most recently
from
b69abec to
137ca2a
Compare
Gold856
previously approved these changes
Dec 8, 2025
Collaborator
|
Rubber stamping for now with the expectation that we'll tag 2026 versions of all artifacts at some other point. |
samfreund
force-pushed
the
dang-it-matt
branch
from
137ca2a to
9175577
Compare
mcm001
reviewed
Dec 9, 2025
samfreund
force-pushed
the
dang-it-matt
branch
from
e143aa4 to
73dc9e9
Compare
Gold856
previously approved these changes
Dec 9, 2025
samfreund
force-pushed
the
dang-it-matt
branch
from
73dc9e9 to
a55fbce
Compare
Gold856
previously approved these changes
Dec 9, 2025
samfreund
force-pushed
the
dang-it-matt
branch
from
a55fbce to
893729f
Compare
Gold856
requested changes
Dec 9, 2025
samfreund
force-pushed
the
dang-it-matt
branch
from
893729f to
25cefa0
Compare
Gold856
approved these changes
Dec 9, 2025
samfreund
added a commit
to samfreund/photonvision
that referenced
this pull request
Dec 18, 2025
…n#2223) ## Description PhotonJNICommon is just our implementation of combined runtime loader, which we don't really need. This removes it and just uses CombinedRuntimeLoader directly. This also fixes the issues introduced in PhotonVision#2219, which lead to some of our JNIs not loading. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [x] If this PR addresses a bug, a regression test for it is added --------- Co-authored-by: Matt M <[email protected]>
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
…n#2223) PhotonJNICommon is just our implementation of combined runtime loader, which we don't really need. This removes it and just uses CombinedRuntimeLoader directly. This also fixes the issues introduced in Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [x] If this PR addresses a bug, a regression test for it is added --------- Co-authored-by: Matt M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PhotonJNICommon is just our implementation of combined runtime loader, which we don't really need. This removes it and just uses CombinedRuntimeLoader directly. This also fixes the issues introduced in #2219, which lead to some of our JNIs not loading.
closes #2211
Meta
Merge checklist: