Skip to content

Fix import for GlobalSettingsCard #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samfreund merged 2 commits into from
Dec 5, 2025
Merged

Fix import for GlobalSettingsCard #2217

samfreund merged 2 commits into from
Dec 5, 2025

Conversation

@Gold856
Copy link
Collaborator

@Gold856 Gold856 commented Dec 5, 2025 •
edited
Loading

Description

Missed in the merge for #2215. This is what I get for merging it with CI being all red :(

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • This PR has been linted.
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner December 5, 2025 17:43
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Dec 5, 2025
@samfreund samfreund enabled auto-merge (squash) December 5, 2025 19:09
@samfreund samfreund merged commit 3ab8bc0 into PhotonVision:main Dec 5, 2025
42 checks passed
@Gold856 Gold856 deleted the fix-globalsetttingscard-rename branch December 6, 2025 10:04
samfreund added a commit to samfreund/photonvision that referenced this pull request Dec 18, 2025
@Gold856 @samfreund
Fix import for GlobalSettingsCard (PhotonVision#2217)
4f66d33 
Co-authored-by: samfreund <[email protected]>
spacey-sooty pushed a commit to spacey-sooty/photonvision that referenced this pull request Dec 22, 2025
@Gold856 @samfreund @spacey-sooty
Fix import for GlobalSettingsCard (PhotonVision#2217)
5b0507d 
Co-authored-by: samfreund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcm001 mcm001 mcm001 approved these changes

@samfreund samfreund samfreund approved these changes

Assignees

No one assigned

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gold856 @mcm001 @samfreund