Update PR linting instructions #2213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
reviewed
Dec 1, 2025
Contributor
mcm001
left a comment
mcm001
left a comment
There was a problem hiding this comment.
I don't mind this being enabled on every failure, not just on pull requests. Also would be great to see an example of this in a job log
samfreund
force-pushed
the
lint-reminder
branch
from
9eb0dc4 to
c20384b
Compare
github-actions
bot
added
the
frontend
samfreund
force-pushed
the
lint-reminder
branch
3 times, most recently
from
995e0c6 to
4b56020
Compare
github-actions
bot
removed
the
frontend
samfreund
force-pushed
the
lint-reminder
branch
5 times, most recently
from
826e0f8 to
afe2c79
Compare
Gold856
requested changes
Dec 4, 2025
Collaborator
Gold856
left a comment
Gold856
left a comment
There was a problem hiding this comment.
You need a set +e to let the script keep going after a non-zero exit code.
samfreund
force-pushed
the
lint-reminder
branch
from
afe2c79 to
d71f41d
Compare
github-actions
bot
added
the
frontend
samfreund
force-pushed
the
lint-reminder
branch
3 times, most recently
from
1e5e227 to
bbd2342
Compare
github-actions
bot
removed
the
frontend
samfreund
force-pushed
the
lint-reminder
branch
from
bbd2342 to
61f92fb
Compare
Gold856
approved these changes
Dec 5, 2025
samfreund
added a commit
to samfreund/photonvision
that referenced
this pull request
Dec 18, 2025
## Description Removes the checkbox for linting because it's easily invalidated by later pushes. Also prints a link to the linting docs on CI failure. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] This PR has been [linted](https://docs.photonvision.org/en/latest/docs/contributing/linting.html). - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
## Description Removes the checkbox for linting because it's easily invalidated by later pushes. Also prints a link to the linting docs on CI failure. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] This PR has been [linted](https://docs.photonvision.org/en/latest/docs/contributing/linting.html). - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the checkbox for linting because it's easily invalidated by later pushes. Also prints a link to the linting docs on CI failure.
Meta
Merge checklist: