Fix incorrect hostname on non-managed devices #2203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backend
Gold856
force-pushed
the
improve-mac-address-detection
branch
2 times, most recently
from
6b6f062 to
d446229
Compare
mcm001
reviewed
Dec 7, 2025
...-core/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
Outdated
Show resolved
Hide resolved
Gold856
force-pushed
the
improve-mac-address-detection
branch
from
d446229 to
af02b77
Compare
Gold856
force-pushed
the
improve-mac-address-detection
branch
from
af02b77 to
fd92bfa
Compare
mcm001
reviewed
Dec 9, 2025
photon-core/src/main/java/org/photonvision/common/networking/NetworkUtils.java
Show resolved
Hide resolved
Gold856
force-pushed
the
improve-mac-address-detection
branch
from
fd92bfa to
a926952
Compare
samfreund
force-pushed
the
improve-mac-address-detection
branch
from
ffebc45 to
b1d66b0
Compare
samfreund
approved these changes
Dec 12, 2025
samfreund
pushed a commit
to samfreund/photonvision
that referenced
this pull request
Dec 18, 2025
I have all sorts of weird adapters from npcap and Hyper-V that don't have MAC addresses, so I'm simplifying the logic down so that it always tries to find _any_ adapter with a MAC address, but attempts to see if it can find what adapter is in use right now and use the MAC address from that. This also unpublishes old MAC address topics, which wasn't done before.
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
I have all sorts of weird adapters from npcap and Hyper-V that don't have MAC addresses, so I'm simplifying the logic down so that it always tries to find _any_ adapter with a MAC address, but attempts to see if it can find what adapter is in use right now and use the MAC address from that. This also unpublishes old MAC address topics, which wasn't done before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have all sorts of weird adapters from npcap and Hyper-V that don't have MAC addresses, so I'm simplifying the logic down so that it always tries to find any adapter with a MAC address, but attempts to see if it can find what adapter is in use right now and use the MAC address from that. This also unpublishes old MAC address topics, which wasn't done before.
Meta
Merge checklist: