Skip to content

Conversation

@mjansen4857
Copy link
Contributor

Description

The current isRK3588 check only catches certain boards. Specifically, Orange Pi 5, Cool Pi 4, and Rock 5C. So, RKNN object detection is not available on boards such as the Radxa CM5, which has an RK3588S chip.

This PR adds an additional check to catch other boards with the RK3588(S) chip by checking for rk3588 in /proc/device-tree/compatible.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • This PR has been linted.
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@mjansen4857 mjansen4857 requested a review from a team as a code owner November 22, 2025 23:26
@mcm001 mcm001 enabled auto-merge (squash) November 22, 2025 23:36
@mcm001 mcm001 merged commit 63593b8 into PhotonVision:main Nov 22, 2025
41 checks passed
samfreund pushed a commit to samfreund/photonvision that referenced this pull request Dec 18, 2025
spacey-sooty pushed a commit to spacey-sooty/photonvision that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants