Add Camera Focus Mode #2180
Merged
Add Camera Focus Mode #2180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
frontend
Member
Just a reminder 😄 |
samfreund
requested changes
Nov 4, 2025
photon-core/src/main/java/org/photonvision/vision/pipe/impl/GrayscalePipe.java
Outdated
Show resolved
Hide resolved
Member
just a heads up, this won't actually close the issue. You need to use the keyword |
github-actions
bot
added
the
documentation
samfreund
requested changes
Nov 10, 2025
Member
samfreund
left a comment
samfreund
left a comment
There was a problem hiding this comment.
We should warn teams that refocusing can lead to their calibration being invalidated.
It seems like we're changing the resolution when we change into focus mode, expected behavior for teams would probably be keeping the same resolution or picking the resolution for focus mode. I'm also unsure of whether this affects focus, if it does it's important to note.
We should consider the case where the focus pipeline is left on by accident, perhaps add a warning/popup modal on the dashboard. If this is implemented here, it should also be done for the calibration mode.
It doesn't seem like the highest focus value is saved and displayed, I believe the intent was to do so. Feel free to correct me if this has changed.
photon-core/src/main/java/org/photonvision/vision/processes/PipelineManager.java
Show resolved
Hide resolved
Co-authored-by: Sam Freund <[email protected]>
samfreund
force-pushed
the
camera-focus-tool
branch
from
b4dff9f to
132be8e
Compare
samfreund
requested changes
Nov 11, 2025
Member
samfreund
left a comment
samfreund
left a comment
There was a problem hiding this comment.
It still doesn't seem that we're saving and displaying the highest focus value, that's something that I think would be helpful and we can save. Otherwise, it's looking pretty good. I left some comments on things that need to get cleaned up, but most of them are nits, so it should be pretty quick to clear up. Also, make sure you remember to lint 😄
samfreund
previously approved these changes
Nov 16, 2025
… not place target too close to the camera.
Gold856
requested changes
Nov 16, 2025
Collaborator
Gold856
left a comment
Gold856
left a comment
There was a problem hiding this comment.
Thanks for working through this!
Gold856
approved these changes
Nov 16, 2025
Gold856
requested changes
Nov 16, 2025
Gold856
requested changes
Nov 16, 2025
Collaborator
Gold856
left a comment
Gold856
left a comment
There was a problem hiding this comment.
Just some consistency things.
Co-authored-by: Gold856 <[email protected]>
Co-authored-by: Gold856 <[email protected]>
Gold856
approved these changes
Nov 16, 2025
samfreund
added a commit
to samfreund/photonvision
that referenced
this pull request
Nov 23, 2025
This reverts commit 618072c.
8 tasks
Gold856
added a commit
that referenced
this pull request
Nov 24, 2025
## Description #2180 added an additional value to PipelineType.java. Enums are serialized with `ordinal()`, and the frontend wasn't updated to account for this, causing an off-by-one error where the UI thought the pipeline was actually the next pipeline over. This resyncs the enum on the frontend to the backend and adjusts the mapping from PipelineType to WebsocketPipelineType to make everything match. Fixes #2201. closes #2202 ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [x] This PR has been [linted](https://docs.photonvision.org/en/latest/docs/contributing/linting.html). - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [x] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
samfreund
pushed a commit
to samfreund/photonvision
that referenced
this pull request
Dec 18, 2025
## Description PhotonVision#2180 added an additional value to PipelineType.java. Enums are serialized with `ordinal()`, and the frontend wasn't updated to account for this, causing an off-by-one error where the UI thought the pipeline was actually the next pipeline over. This resyncs the enum on the frontend to the backend and adjusts the mapping from PipelineType to WebsocketPipelineType to make everything match. Fixes PhotonVision#2201. closes PhotonVision#2202 ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [x] This PR has been [linted](https://docs.photonvision.org/en/latest/docs/contributing/linting.html). - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [x] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
## Description Camera focus tool pipeline using a Laplacian and finding the variance. Similar to Limelight. closes PhotonVision#1597 ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [x] This PR has been [linted](https://docs.photonvision.org/en/latest/docs/contributing/linting.html). - [x] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [x] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
## Description PhotonVision#2180 added an additional value to PipelineType.java. Enums are serialized with `ordinal()`, and the frontend wasn't updated to account for this, causing an off-by-one error where the UI thought the pipeline was actually the next pipeline over. This resyncs the enum on the frontend to the backend and adjusts the mapping from PipelineType to WebsocketPipelineType to make everything match. Fixes PhotonVision#2201. closes PhotonVision#2202 ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [x] This PR has been [linted](https://docs.photonvision.org/en/latest/docs/contributing/linting.html). - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [x] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Camera focus tool pipeline using a Laplacian and finding the variance. Similar to Limelight.
closes #1597
Meta
Merge checklist: