-
Notifications
You must be signed in to change notification settings - Fork 268
Add message discouraging chessboard usage #2160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
photon-core/src/main/java/org/photonvision/vision/pipe/impl/FindBoardCornersPipe.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Nitpick: this PR has different capitalization for charuco than we typically use. If you want to go through and change capitalization everywhere else, feel free to do so. Otherwise, just change your capitalization to follow what we typically do.
Also, if you can run the linting, that would be great.
00a4045 to
0bb7cf2
Compare
|
I went ahead and linted for you just so you know. I'm realizing we don't actually have a writeup on how to do that 😬 so I'm going to go ahead and do that rq |
Thanks, I was struggling with figuring that out, I don't normally do JS development so idk much about Vue linters 😭... |
That's what the writeup is for! Thanks for helping me figure out we don't have one 😆 |
Description
I added a warning to inform teams that the 8x8 chessboard can cause bad calibration results, and that the chArUco board should be used instead.
This is my first time contributing to this repo, so please let me know if there's anywhere else I should add this warning. 😄
This PR closes #1515.
Meta
Merge checklist: