Skip to content

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Oct 23, 2025

Description

During the move to Vue 3 (see #1900), the default calibration for resolution wasn't properly set. This fixes the issue.

closes #2145

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner October 23, 2025 20:14
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Oct 23, 2025
@samfreund samfreund changed the title Fix calibration resolution default issue Fix calibration resolution default bug Oct 23, 2025
@samfreund samfreund force-pushed the fix-calib-res-default branch from 94e9aae to 1ba2578 Compare October 23, 2025 21:36
@Gold856
Copy link
Collaborator

Gold856 commented Oct 23, 2025

I get 1920x1080 defaulted on page reload despite the fact that it's not an option. Otherwise, it's blank. This is with a camera with no video modes.

@Gold856
Copy link
Collaborator

Gold856 commented Oct 23, 2025

What's the default resolution supposed to be?

@samfreund
Copy link
Member Author

samfreund commented Oct 23, 2025

What's the default resolution supposed to be?

Whatever the camera's current resolution is

@Gold856
Copy link
Collaborator

Gold856 commented Oct 23, 2025

Placeholder Camera has nothing selected by default now, which feels odd.

@samfreund samfreund force-pushed the fix-calib-res-default branch from 6d5d724 to 1ba2578 Compare October 23, 2025 23:58
@samfreund samfreund merged commit 9f6d8ca into PhotonVision:main Oct 24, 2025
54 of 75 checks passed
@samfreund samfreund deleted the fix-calib-res-default branch October 24, 2025 04:42
spacey-sooty pushed a commit to spacey-sooty/photonvision that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default calibration resolution bug

2 participants