Skip to content

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Oct 23, 2025

Description

This replaces boilerplate that checks whether we've successfully sent the request, whether there was an error, etc.

closes #2151

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner October 23, 2025 06:05
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Oct 23, 2025
@samfreund samfreund force-pushed the post-function branch 2 times, most recently from 70030d1 to 6312de0 Compare October 23, 2025 06:08
@Gold856 Gold856 merged commit 695742b into PhotonVision:main Nov 1, 2025
41 checks passed
@samfreund samfreund deleted the post-function branch November 2, 2025 22:34
spacey-sooty pushed a commit to spacey-sooty/photonvision that referenced this pull request Dec 22, 2025
## Description

This replaces boilerplate that checks whether we've successfully sent
the request, whether there was an error, etc.

closes PhotonVision#2151

## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with settings back to v2025.3.2
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce boilerplate for API request and snackbar update

3 participants