Use the tool plugin to include photon-targeting into photon-core #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backend
Gold856
force-pushed
the
photon-targeting-tool-plugin
branch
from
2742faf to
3d9b64a
Compare
Collaborator
Author
|
Needs the loading to actually be changed. |
github-actions
bot
added
the
photonlib
Gold856
force-pushed
the
photon-targeting-tool-plugin
branch
from
ee56037 to
d09bf8b
Compare
github-actions
bot
added
the
documentation
Gold856
force-pushed
the
photon-targeting-tool-plugin
branch
from
9d15352 to
826764e
Compare
mcm001
previously approved these changes
Oct 20, 2025
Collaborator
Author
|
Confirmed to work on an Orange Pi, Windows 11 sim, and roboRIO. On a roboRIO, it'll crash with an IOException if photon-targeting can't be loaded. |
Gold856
force-pushed
the
photon-targeting-tool-plugin
branch
from
826764e to
6880958
Compare
github-actions
bot
removed
the
documentation
Gold856
force-pushed
the
photon-targeting-tool-plugin
branch
from
6880958 to
5d2e353
Compare
mcm001
approved these changes
Oct 20, 2025
photon-lib/src/main/java/org/photonvision/timesync/TimeSyncSingleton.java
Show resolved
Hide resolved
7 tasks
mcm001
pushed a commit
that referenced
this pull request
Dec 7, 2025
## Description #2137 made it so `TestUtils.loadLibraries()` loads both WPILib and photon-targeting, which is used in Main.java to load libraries, but it left the separate photon-targeting load in Main. This removes the extra library load, since it's covered by `TestUtils.loadLibraries()`. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
samfreund
pushed a commit
to samfreund/photonvision
that referenced
this pull request
Dec 18, 2025
## Description PhotonVision#2137 made it so `TestUtils.loadLibraries()` loads both WPILib and photon-targeting, which is used in Main.java to load libraries, but it left the separate photon-targeting load in Main. This removes the extra library load, since it's covered by `TestUtils.loadLibraries()`. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
…tonVision#2137) This allows photon-targeting to be loaded using the same mechanism as the rest of the WPILib libraries, fixing issues with libraries not being able to find and load their dependent libraries. Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [x] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows photon-targeting to be loaded using the same mechanism as the rest of the WPILib libraries, fixing issues with libraries not being able to find and load their dependent libraries.
Meta
Merge checklist: