[NFC] Invert AprilTag family default #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backend
samfreund
previously approved these changes
Oct 13, 2025
Contributor
|
I'm not sure this PR actually changes our behacior, does it? |
Member
It doesn't, it just makes it more clear what our default values are. Arguably it provides some optimization, but idt that's significant. This is more just a readability change, which imo is a good thing. |
photon-core/src/main/java/org/photonvision/vision/pipeline/AprilTagPipeline.java
Outdated
Show resolved
Hide resolved
mcm001
changed the title
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
samfreund
force-pushed
the
invert-default
branch
from
ec66f50 to
24821b6
Compare
samfreund
approved these changes
Oct 23, 2025
Gold856
requested changes
Nov 1, 2025
photon-core/src/test/java/org/photonvision/vision/pipeline/AprilTagTest.java
Show resolved
Hide resolved
Gold856
approved these changes
Nov 2, 2025
spacey-sooty
added a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
## Description Switch default tag family used in AprilTag pipeline. We already functionally changed the default in PhotonVision#1333 but since 2024 FIRST appears to have been using 36h11 so switching here seems to make sense as well. ## Meta Merge checklist: - [ ] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [x] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added --------- Signed-off-by: Jade Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch default tag family used in AprilTag pipeline. We already functionally changed the default in #1333 but since 2024 FIRST appears to have been using 36h11 so switching here seems to make sense as well.
Meta
Merge checklist: