Skip to content

Conversation

vishnunaini
Copy link
Contributor

@vishnunaini vishnunaini commented Dec 26, 2024

  1. Use common transport for api calls
  2. Initialiser server ID=0 for new upstream that doesn't exist as UpdateHTTPServers relies on GetHTTPServers to return valid data to determine diff to update
  3. Wait for newly initialised upstream to return valid data

@santanusinha santanusinha merged commit cfb4944 into PhonePe:master Dec 26, 2024
@vishnunaini vishnunaini deleted the nginx-plus-client branch December 30, 2024 08:11
@vishnunaini vishnunaini restored the nginx-plus-client branch December 30, 2024 08:12
@vishnunaini
Copy link
Contributor Author

This is a workaround till nginx client is updated to v2.2+ as the workaround is not necessary with this fix although the 404 behaviour isn't fixed nginx/nginx-plus-go-client#422

vishnunaini pushed a commit that referenced this pull request Jan 23, 2025
rename symbols and logging changes for readabillity and monitoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants