Skip to content

Support YRpp spawner's MP saves #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Metadorius
Copy link
Member

@Metadorius Metadorius commented Jul 29, 2025

Also see CnCNet/yrpp-spawner#48. You should test this PR with any recent YRpp spawner version with MP saves, should work.

Scenarios to test:

  • quicksave
  • save game trigger action

Conditions:

  • online with YRpp spawner (should work)
  • online with old cncnet5.dll / old YRpp spawner without support for MP saves

Copy link

github-actions bot commented Jul 29, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Metadorius
Copy link
Member Author

Took over the XNA client's handling of savegames. This should fix the "saving too fast" issue.

Please verify all previously faulting scenarios, and in addition to that also verify if the saves in skirmish/campaign are alright still, also verify that saves are alright with old cncnet5.dll.

@Metadorius Metadorius merged commit 937822b into Phobos-developers:develop Aug 11, 2025
6 checks passed
@Metadorius Metadorius deleted the feature/savegame-spawner-compat branch August 11, 2025 20:36
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Aug 15, 2025
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants