Add EnumDiscriminants Trait and related Macro impl#377
Merged
Peternator7 merged 2 commits intoPeternator7:masterfrom Sep 29, 2024
Merged
Conversation
mohe2015
approved these changes
Sep 24, 2024
mohe2015
left a comment
There was a problem hiding this comment.
Tested my crate with the new changes.
|
I should note that these changes break the following user code: #[derive(EnumDiscriminants)]
#[strum_discriminants(name(PrivateDiscriminants), vis(pub(self)))]
pub enum PublicEnum {
Variant0(bool),
Variant1 { a: bool },
}The error message is: This is because the |
Owner
|
fixed in #409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has for goal to implement and resolve #376 as well as #176