Add various common files to standard MANIFEST.SKIP #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leont
reviewed
May 23, 2025
| @@ -38,6 +39,11 @@ | |||
| # and Module::Build::Tiny generated files | |||
| \b_build_params$ | |||
|
|
|||
| ^local/ # Carton local library | |||
There was a problem hiding this comment.
I'm slightly confused what a carton local library would be doing in a CPAN dist.
There was a problem hiding this comment.
A lot of cpan dists have a cpanfile, so a developer or contributor can use carton to install dist-specific prereqs in the local lib, work on that distribution without polluting their global Perl.
It also helps for things like temporarily installing a different version of a prereq, or adding/removing an optional prereq etc.
There was a problem hiding this comment.
(Come to think of it, the cpanfile.snapshot should probably be excluded too.)
There was a problem hiding this comment.
I see. Not a workflow I'd use, but it makes enough sense.
Leont
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.