Attempt #2 stopping test erosion #27
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a rehash of #19 aiming to simplify the situation, and remove swathes of contemptuos code.
The biggest downside now from this test is that it doesn't have the Test::TempDir::Tiny magic that shits stuff in ./tmp/ with a pretty path name.
Instead, something as effective, but much simpler is used:
Its not as "nice"... but probably sufficient.
All the faff in my other PR has been basically inlined where needed.
HOWEVER
Both in this test iteration, and the one before it, doing:
Fails test 2:
Whereas that test does not fail without
-Ilib
.But the tests pass properly with
dzil test
Somebody needs to investigate what the fuck is happening here.
That looks like some funky fragile logic happening.