Add write.events.SIPNET function#3623
Merged
infotroph merged 34 commits intoPecanProject:developfrom Oct 26, 2025
Merged
Conversation
infotroph
reviewed
Sep 21, 2025
infotroph
requested changes
Sep 24, 2025
Co-authored-by: Chris Black <chris@ckblack.org>
dlebauer
commented
Sep 25, 2025
dlebauer
commented
Sep 25, 2025
dlebauer
commented
Sep 25, 2025
infotroph
requested changes
Sep 25, 2025
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Member
@dlebauer seems like the proximal issue is the entries in events_site1.json being list instead of scalar, but I don't understand the intention behind that format enough to recommend a fix. |
infotroph
approved these changes
Oct 4, 2025
Member
|
@dlebauer reminder that this PR is still waiting for your input -- ping me if you want help on the test failures, but I'll need context from you to suggest the right fix. |
dlebauer
commented
Oct 15, 2025
dlebauer
commented
Oct 15, 2025
… from sipnet to data.land package
Member
Author
|
@infotroph if you want to take another look at the changes that I've made (f800475...dlebauer:write_events_sipnet) while trying to get the tests to pass, they include
|
infotroph
requested changes
Oct 16, 2025
infotroph
reviewed
Oct 16, 2025
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
infotroph
approved these changes
Oct 20, 2025
…(3.1.0 was released in 2021) - add test that validate_events_json return NA if jsonvalidate not installed
Merged
via the queue into
PecanProject:develop
with commit Oct 26, 2025
13678ab
19 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add function that converts a generic
events.json(see #3621 and #3551) into sipnet-specificevents.infiles.Description
Includes:
write.events.SIPNETMotivation and Context
Required to use PEcAn to configure SIPNET to simulate agronomic managements.
Review Time Estimate
Types of changes
Checklist: