Keep using *.nc.var in web and API#3616
Merged
infotroph merged 4 commits intoPecanProject:developfrom Sep 22, 2025
Merged
Conversation
Member
Author
dlebauer
approved these changes
Sep 22, 2025
Merged
via the queue into
PecanProject:develop
with commit Sep 22, 2025
733cded
18 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing from #3611, which turned creation of
*.nc.varoff by default, by re-enabling it for the web workflow and API. These are the only known places that rely on these files.Description
settings$nc_varfile_modeto "paired" at settings generation time, prompting workflow.R to callnc_write_varfiles. Output will remain identical to the existing default.getWorkflowsAPI endpoint will still read*.nc.varif they exist (for compatibility with existing runs), but will also write one combinednc_vars.txtfor the whole outdir and use that for any*.ncthat does not have a paired*.nc.varcannot remove file '/your/outdir/1999.nc.var', reason 'No such file or directory', but this should not stop execution.Motivation and Context
@mdietze in #3611 :
Review Time Estimate
Types of changes
Checklist: