Skip to content

Remove VM instructions from install_pecan#3478

Merged
dlebauer merged 8 commits intodevelopfrom
remove_vm
Mar 10, 2025
Merged

Remove VM instructions from install_pecan#3478
dlebauer merged 8 commits intodevelopfrom
remove_vm

Conversation

@dlebauer
Copy link
Copy Markdown
Member

@dlebauer dlebauer commented Mar 10, 2025

Description

This PR removes references to the VM from PEcAn documentation.

Motivation and Context

Since getting Docker up and running, we retired the VM and the latest available is v1.7.2

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there other info in the other docs?

@dlebauer
Copy link
Copy Markdown
Member Author

@robkooper just removed everything explicitly referencing the PEcAn VM; left references to VMs as a way of explaining Docker (though yeah, maybe these are outdated now that Docker is more familiar) and as synonyms for server, e.g. in AWS cloud.

@dlebauer dlebauer added this to the 1.9.0 milestone Mar 10, 2025
@dlebauer dlebauer added this pull request to the merge queue Mar 10, 2025
Merged via the queue into develop with commit afc98ad Mar 10, 2025
29 checks passed
@dlebauer dlebauer deleted the remove_vm branch March 11, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants