Skip to content

fix for #1545#1584

Merged
mdietze merged 2 commits intodevelopfrom
fix-remote-execution
Aug 15, 2017
Merged

fix for #1545#1584
mdietze merged 2 commits intodevelopfrom
fix-remote-execution

Conversation

@robkooper
Copy link
Copy Markdown
Member

@robkooper robkooper commented Aug 15, 2017

Fix remote code execution in dataset.php, this is only executable by providing a malicious url, and not from the web interface.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes remote code execution #1545)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@robkooper
Copy link
Copy Markdown
Member Author

@tonygardella tonygardella self-requested a review August 15, 2017 19:38
@tonygardella
Copy link
Copy Markdown
Contributor

Assigned myself because I'm matched with Rob this week for code review.

### Fixes
- Fixed remote code execution #1545

## [1.5.10] - Prerelease
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to: ## [1.5.0]- 2017-07-13

@tonygardella
Copy link
Copy Markdown
Contributor

If you don't have time to make that edit to the change log I can do that later. I'd rather this get merged asap.

@mdietze mdietze merged commit 4b67541 into develop Aug 15, 2017
@robkooper robkooper deleted the fix-remote-execution branch February 12, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remote code execution

3 participants