Check T corrections in FitA

[dlebauer]

Bug Description

leafT is converted to K in fitA only when there is no leafT provided

Bug Description

• add sensible Tleaf range checks to determine if values are in C e.g. if < 100 it is C, else K (most users will be providing C)
  • if so, convert leafT to K
• double check math on Bernacchi 2001 coefficients (Table 1) and fix c
• double check the units in June 2004 and fix To
• if leafT is not provided, but temperature corrections are turned on, send user a warning

From Slack https://pecanproject.slack.com/archives/C8RD9BRLK/p1603968127096900?thread_ts=1603946826.096600&cid=C8RD9BRLK

[infotroph]

@dlebauer Can this be closed or is there more to do here that #2727 didn't address?

[dlebauer]

There is more to do - #2727 only implemented:

1. Check if Tleaf provided in C and if so, converts to K
2. set Tleaf to 25C if not provided, with warning

Unchecked issues in the original post are still remaining:

1. double check math on Bernacchi coefficients (Table 1) and fix c
2. check the units in June 2004 and fix To

[github-actions]

This issue is stale because it has been open 365 days with no activity.