Skip to content

run.biocro return values do not vary #1738

@infotroph

Description

@infotroph
> out <- PEcAn.BIOCRO::run.biocro(lat, lon,
+                  metpath = metpath,
+                  soil.nc = soil.nc, 
+                  config = config)
> head(out$daily)
       lat      lon year doy     Stem     Leaf     Root
1: 40.0061 -88.2919 2004   1 45.79881 5.711558 3.674523
2: 40.0061 -88.2919 2004   2 45.79881 5.711558 3.674523
3: 40.0061 -88.2919 2004   3 45.79881 5.711558 3.674523
4: 40.0061 -88.2919 2004   4 45.79881 5.711558 3.674523
5: 40.0061 -88.2919 2004   5 45.79881 5.711558 3.674523
6: 40.0061 -88.2919 2004   6 45.79881 5.711558 3.674523
# <snip>
> length(unique(out$daily$Leaf))
[1] 1

This is a regression caused by the changes in #1620 -- the summary code is now taking max/sum across entire run rather than within days.

I have a fix in progress.

Description

Context

Possible Implementation

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions