This repository was archived by the owner on Mar 8, 2024. It is now read-only.
Fix payid+json incorrect 200 error #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xCLARITY
commented
Jul 14, 2020
| message += `on ${environment} ` | ||
| } | ||
| message += 'could not be found.' | ||
| } |
There was a problem hiding this comment.
This felt complicated for no real reason, so I just cut it.
There was a problem hiding this comment.
Definitely a little much for the error message.
| @@ -57,6 +57,10 @@ export function getPreferredAddressHeaderPair( | |||
| preferredAddresses: readonly AddressInformation[] | |||
| } | |||
| | undefined { | |||
| if (allAddresses.length === 0) { | |||
| return undefined | |||
| } | |||
There was a problem hiding this comment.
This was the bug. By not returning undefined when we had no addresses, we would fail our if(x === undefined) check in the middleware, and not 404 correctly.
| @@ -147,8 +147,7 @@ describe('E2E - publicAPIRouter - Base PayID', function (): void { | |||
| const expectedErrorResponse = { | |||
| statusCode: 404, | |||
| error: 'Not Found', | |||
| message: | |||
| 'Payment information for johndoe$127.0.0.1 in XRPL on TESTNET could not be found.', | |||
| message: 'Payment information for johndoe$127.0.0.1 could not be found.', | |||
There was a problem hiding this comment.
Update random test messages because I changed the 404 not found message.
| // THEN we get back a 404 with the expected error response. | ||
| .expect(HttpStatus.NotFound, expectedErrorResponse, done) | ||
| // }) | ||
| }) |
There was a problem hiding this comment.
This is the test that verifies we no longer have a bug in our header processing logic.
dino-rodriguez
approved these changes
Jul 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fix bug in header processing logic, and remove needlessly complex logic for the "Not Found" message we provide.
Context of Change
There was a bug in our header processing logic, which, if you requested
payid+jsonto a non-existent PayID would respond with a200 - OK, claiming that PayID existed with no addresses, rather than responding with a404 - Not Found.Relevant issue: #595
Type of Change
Test Plan
Added a test for the
payid+jsonto a nonexistent PayID case, and it now passes (would fail onmaster).