fixing import users script; .include? method implementation throwing errors #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…previously set on the condition that the contact method type was phone or sms, however, the include method was throwing an error and this extra condition seemed redundant. Also fixed how the script defaults to observer for team role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link back to Jira ticket:
Description
The
.include?method was creating errors in several places. One implementation of it checked to see if a contact method type was sms or phone before adding the country code to the request body. That seemed unnecessary to me, so this version includes the country code by default. The code that determines if a user should be set to observer for a team role used theincludemethod and I changed it to just check if the base role is stakeholder, limited stakeolder, or observer instead of seeing if base role includedread_only.