Skip to content

[CodeStyle][Typos][O-[15-20],O-[24-26]] Fix typos(optin, Optin, rder, oreder, orignal, orginal, onces, outter, outpus, overriden, Overide, overide, overrided) #70759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 17, 2025
Merged

[CodeStyle][Typos][O-[15-20],O-[24-26]] Fix typos(optin, Optin, rder, oreder, orignal, orginal, onces, outter, outpus, overriden, Overide, overide, overrided) #70759

merged 25 commits into from
Jan 17, 2025

Conversation

LanCole
Copy link
Contributor

@LanCole LanCole commented Jan 9, 2025 •
edited
Loading

PR Category

User Experience

PR Types

Devs

Description

fixed:
rder,
oreder,
orignal,
orginal,
onces,
outter,
outpus,
overriden,
Overide,
overide,
overrided

Undo:
optin, 不确定是否正确， .clang-tidy文件中存在typos error，不修改 .clang-tidy 文件，因此添加到 _typos.toml files.extend-exclude

Optin, 不确定如何修改，所以改回

@LanCole LanCole requested a review from SigureMo as a code owner January 9, 2025 20:18
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jan 9, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 9, 2025
@LanCole LanCole changed the title [CodeStyle][Typos][O-[15-20],O-[24-26]] Fix typo(optin, Optin, rder, oreder, orignal, orginal, onces, outter, outpus, overriden, Overide, overide, overrided) [CodeStyle][Typos][O-[15-20],O-[24-26]] Fix typos(optin, Optin, rder, oreder, orignal, orginal, onces, outter, outpus, overriden, Overide, overide, overrided) Jan 9, 2025
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 10, 2025
@LanCole
Copy link
Contributor Author

LanCole commented Jan 10, 2025

请问CodeStyle-check中报错，在pre-commit run之后出现这些failed提示，需要怎么解决呢？
image

luotao1
luotao1 reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要修改 .clang-tidy 文件

@LanCole
Copy link
Contributor Author

LanCole commented Jan 10, 2025 •
edited
Loading

不要修改 .clang-tidy 文件

好的收到。

我是看到了pre-commit提示的.clang-tidy中的failed error后修改的，有些理解错误，想问一下这里的failed提示怎么处理呢？
image

@LanCole LanCole requested a review from luotao1 January 10, 2025 08:38
@SigureMo SigureMo mentioned this pull request Jan 11, 2025
Closed
@SigureMo
Copy link
Member

加到 _typos.toml files.extend-exclude

@LanCole
Copy link
Contributor Author

LanCole commented Jan 11, 2025

加到 _typos.toml files.extend-exclude

好的，收到

@LanCole
Copy link
Contributor Author

LanCole commented Jan 11, 2025

加到 _typos.toml files.extend-exclude

已经修改并提交代码了

@SigureMo
Copy link
Member

codestyle 检查都没过

@LanCole
Copy link
Contributor Author

LanCole commented Jan 11, 2025

codestyle 检查都没过

好的收到，代码修正后codestyle检查已经通过，再次提交了

@SigureMo
Copy link
Member

PR 导致的编译问题定位下，CI 都挂了，自己先看下

SigureMo
SigureMo reviewed Jan 11, 2025
View reviewed changes
_typos.toml Outdated
"paddle/fluid/inference/tensorrt/convert/generic_and_custom_plugin_creater.cc",
"paddle/fluid/inference/tensorrt/convert/test_custom_plugin_creater.cc",
".clang-tidy",
"paddle/phi/kernels/gpu/rms_norm_kernel.cu",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件是因为什么原因加入的？为什么没有任何说明？

SigureMo
SigureMo requested changes Jan 11, 2025
View reviewed changes
paddle/phi/kernels/gpu/rms_norm_kernel.cu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

明显不对

SigureMo
SigureMo requested changes Jan 12, 2025
View reviewed changes
_typos.toml Outdated
Operants = 'Operants'
operants = 'operants'
optin = 'optin'
Optin = 'Optin'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移到上面的 「PaddlePaddle specific words」，字母序

_typos.toml Outdated
"paddle/fluid/inference/tensorrt/convert/CMakeLists.txt",
"paddle/fluid/inference/tensorrt/convert/generic_and_custom_plugin_creater.cc",
"paddle/fluid/inference/tensorrt/convert/test_custom_plugin_creater.cc",
".clang-tidy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optin word 级 ignore 之后就不用加这行了吧？

@LanCole LanCole requested a review from SigureMo January 13, 2025 08:14
SigureMo
SigureMo requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI 这不是全挂了吗？所有 optin 都恢复

paddle/phi/kernels/fusion/cutlass/cutlass_extensions/compute_occupancy.h Outdated
if (status == cudaError::cudaErrorInvalidValue) {
// Clear the error bit since we can ignore this.
// This should mean that smem_size >
// Undo Optin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是干啥？

@luotao1
Copy link
Contributor

luotao1 commented Jan 14, 2025

@BaolanChen 可以这个PR不认领 optin和Optin，先把其他的搞定

@SigureMo
Copy link
Member

@BaolanChen 可以这个PR不认领 optin和Optin，先把其他的搞定

这个直接在配置 ignore 就可以

SigureMo
SigureMo reviewed Jan 14, 2025
View reviewed changes
_typos.toml Outdated
pash = 'pash'
unpacket = "unpacket"
vaccum = 'vaccum'
Optin = 'Optin'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

位置不对，没按字母序

@LanCole
Copy link
Contributor Author

LanCole commented Jan 14, 2025

@BaolanChen 可以这个PR不认领 optin和Optin，先把其他的搞定

收到，尽快搞定

@LanCole
Copy link
Contributor Author

LanCole commented Jan 14, 2025 •
edited
Loading

CI 这不是全挂了吗？所有 optin 都恢复

收到，Optin添加到ignore中，其他Optin的修改都恢复了。代码修正后重新提交了。

@LanCole LanCole requested a review from SigureMo January 14, 2025 12:47
@SigureMo
Copy link
Member

CI 过了再 request review，就算是 commit 我也看得到

SigureMo
SigureMo approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 6359473 into PaddlePaddle:develop Jan 17, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

@luotao1 luotao1 Awaiting requested review from luotao1

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LanCole @SigureMo @luotao1