Skip to content

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 7, 2025

PR Category

User Experience

PR Types

Devs

Description

fixed:
indiates,
indeces,
inferrence,
infering,
imformation,
infomation,
informations,
Infor,
infor,
inheritted,
initilization

Copy link

paddle-bot bot commented Jan 7, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 7, 2025
'test_sync_batch_norm_pass',
'test_switch',
'test_static_shape_inferrence_for_shape_tensor',
'test_static_shape_inference_for_shape_tensor',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这俩单测是不是不存在了啊,不存在了的话这俩直接删掉就好

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

def _pack_loaded_dict(load_obj):
if isinstance(load_obj, dict):
unpack_info = 'UnpackBigParamInfor@@'
unpack_info = 'UnpackBigParamInfo@@'
Copy link
Member

@SigureMo SigureMo Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里感觉会有兼容性问题,需要恢复下,272 行同

麻烦参考 https://github.com/crate-ci/typos/blob/master/docs/reference.md#example-configurations

_typos.toml 配置下局部 ignore 的指令:

# 加在 extend-ignore-words-re 下面
extend-ignore-re = [
    # Ignore lines by `# typos: disable-line`
    "(?Rm)^.*(#|//)\\s*typos:\\s*disable-line$",
    # Ignore block by `# typos: off` and `# typos: on`
    "(?s)(#|//)\\s*typos:\\s*off.*?\\n\\s*(#|//)\\s*typos:\\s*on"
]

并在这两行添加 # typos: disable-line 试试

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 7, 2025
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit e8c33cd into PaddlePaddle:develop Jan 8, 2025
30 of 31 checks passed
@enkilee enkilee deleted the typo-i12 branch January 21, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants