【Paddle Tensor No.26】Svdvals new branch #69796

aquagull · 2024-11-28T09:29:18Z

PR Category

User Experience

PR Types

New features

Description

【Paddle Tensor No.26】Svdvals new branch
#69082

paddle-bot · 2024-11-28T09:29:23Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle/phi/kernels/cpu/svdvals_kernel.cc

HydrogenSulfate · 2024-11-29T02:27:30Z

test/legacy_test/test_svdvals_op.py

+@skip_check_grad_ci(
+    reason="'check_grad' on singular values is not required for svdvals."
+)


这个打开后在aistudio机器上要运行多久呢？

这个打开后在aistudio机器上要运行多久呢？

这个还没测试过来着

这个打开后在aistudio机器上要运行多久呢？

这个还没测试过来着

几百x几百规模的svd应该很快的，几十或者几百毫秒就能跑，你可以打开本地测试一下

这个打开后在aistudio机器上要运行多久呢？

这个还没测试过来着

几百x几百规模的svd应该很快的，几十或者几百毫秒就能跑，你可以打开本地测试一下

好的我本地编译测试一下

HydrogenSulfate · 2024-11-29T02:28:35Z

test/legacy_test/test_svdvals_op.py

+
+        np_s = np.linalg.svd(self.x_np, compute_uv=False, hermitian=False)
+        for r in res:
+            self.assertTrue(np.allclose(np_s, r, rtol=1e-6))


下个PR把所有的assertTrue(allclose)用np.testing.assert_allclose代替，这样错误信息会更清晰

Suggested change

self.assertTrue(np.allclose(np_s, r, rtol=1e-6))

np.testing.assert_allclose(np_s, r, rtol=1e-6))

下个PR把所有的assertTrue(allclose)用np.testing.assert_allclose代替，这样错误信息会更清晰

了解

HydrogenSulfate · 2024-11-29T02:32:24Z

python/paddle/tensor/linalg.py

+    if in_dynamic_or_pir_mode():
+        return _C_ops.svdvals(x)
+    else:
+        check_variable_and_dtype(x, 'dtype', ['float32', 'float64'], 'svdvals')
+        helper = LayerHelper('svdvals', **locals())
+        s = helper.create_variable_for_type_inference(dtype=x.dtype)
+        attrs = {}
+        helper.append_op(
+            type='svdvals',
+            inputs={'X': [x]},
+            outputs={'S': s},
+            attrs=attrs,
+        )
+        return s


下个PR再把老IR的分支删了

Suggested change

if in_dynamic_or_pir_mode():

return _C_ops.svdvals(x)

else:

check_variable_and_dtype(x, 'dtype', ['float32', 'float64'], 'svdvals')

helper = LayerHelper('svdvals', **locals())

s = helper.create_variable_for_type_inference(dtype=x.dtype)

attrs = {}

helper.append_op(

type='svdvals',

inputs={'X': [x]},

outputs={'S': s},

attrs=attrs,

)

return s

return _C_ops.svdvals(x)

Copilot

Copilot reviewed 5 out of 17 changed files in this pull request and generated no suggestions.

Files not reviewed (12)

paddle/cinn/hlir/dialect/operator/ir/op_dialect.cc: Language not supported
paddle/fluid/pir/dialect/operator/ir/op_dialect.cc: Language not supported
paddle/fluid/pir/dialect/operator/ir/op_onednn_dialect.cc: Language not supported
paddle/phi/infermeta/unary.cc: Language not supported
paddle/phi/infermeta/unary.h: Language not supported
paddle/phi/kernels/cpu/svdvals_grad_kernel.cc: Language not supported
paddle/phi/kernels/cpu/svdvals_kernel.cc: Language not supported
paddle/phi/kernels/impl/svdvals_grad_kernel_impl.h: Language not supported
paddle/phi/kernels/svdvals_grad_kernel.h: Language not supported
paddle/phi/kernels/svdvals_kernel.h: Language not supported
paddle/phi/ops/yaml/backward.yaml: Evaluated as low risk
paddle/phi/ops/yaml/ops.yaml: Evaluated as low risk

SigureMo

LGTMeow

SigureMo · 2024-11-29T02:33:09Z

test/legacy_test/test_svdvals_op.py

@@ -0,0 +1,158 @@
+#   Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.


Suggested change

# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.

# Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved.

我在下一个pr里更改吧

SigureMo · 2024-11-29T02:45:02Z

paddle/fluid/pir/dialect/op_generator/op_gen.py

+            n = len(op_list_strs) // 4
            first_part_op_info = op_list_strs[:n]
-            second_part_op_info = op_list_strs[n:]
+            second_part_op_info = op_list_strs[n : 2 * n]
+            third_part_op_info = op_list_strs[2 * n : 3 * n]
+            fourth_part_op_info = op_list_strs[3 * n :]


n_parts = 4 part_size = math.ceil(len(op_list_strs) / n_part) op_list_parts = [op_list_strs[part_offset:part_offset + part_size] for part_offset in range(0, len(op_list_strs), part_size)]

后续可以考虑以更易于维护的方式来扩展

n_parts = 4 part_size = math.ceil(len(op_list_strs) / n_part) op_list_parts = [op_list_strs[part_offset:part_offset + part_size] for part_offset in range(0, len(op_list_strs), part_size)]

后续可以考虑以更易于维护的方式来扩展

好的谢谢佬

XiaoguangHu01

LGTM

aquagull and others added 30 commits November 17, 2024 19:31

add svdvals_kernel

6804a7d

fix bug

6183311

fix bug

f6dce63

fix bug

f27b4c7

fix bug

46d6fff

fix some bug

cf42122

fix bug

cb428b2

fix bug

3a1110c

fix bug

a729ef6

add include

99dbd3b

fix bug in svdvals_kernel

a008105

fix bug

963e03a

fix bug

9824e90

fix bug in func SvdvalsInferMeta

9f8a548

add test

681cad9

Merge branch 'PaddlePaddle:develop' into addSvdvals

fd97a58

fix codestyle

4d9c7ce

fix lwork and int

cc1a1ae

fix

e26cb76

use guard to control enable/disable

7ee7eb9

add test_check_grad

d3131bf

fix test_svdvals_op

c1a1c48

fix bug

aa92a7a

fix bug in svdvals_kernel

f246347

fix bug

0267c37

fix bug

b5470b8

fix bug

f86541e

fix bug in svdvals_grad_kernel

73a53d6

fix

e439a2b

fix

4135e24

aquagull added 5 commits November 25, 2024 20:08

fix bug in svdvals_grad_kernel

b37f96b

fix

7a09e29

fix

290b201

fix

2ffa2a0

fix

46e4219

paddle-bot bot added the contributor External developers label Nov 28, 2024

luotao1 assigned luotao1 and HydrogenSulfate Nov 28, 2024

luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 28, 2024

aquagull force-pushed the svdvals_new_branch branch from 17bd7a4 to 46e4219 Compare November 28, 2024 10:52

luotao1 mentioned this pull request Nov 28, 2024

【快乐开源】Paddle Tensor 规范化 #69082

Closed

delete VLOG

6099878

HydrogenSulfate reviewed Nov 28, 2024

View reviewed changes

paddle/phi/kernels/cpu/svdvals_kernel.cc Outdated Show resolved Hide resolved

aquagull added 3 commits November 28, 2024 19:37

delete head

e5b0039

fix

a4f8235

fix op_gen

dd419d2

HydrogenSulfate reviewed Nov 29, 2024

View reviewed changes

SigureMo requested a review from Copilot November 29, 2024 02:32

HydrogenSulfate reviewed Nov 29, 2024

View reviewed changes

Copilot AI reviewed Nov 29, 2024

View reviewed changes

luotao1 approved these changes Nov 29, 2024

View reviewed changes

SigureMo approved these changes Nov 29, 2024

View reviewed changes

zyfncg approved these changes Nov 29, 2024

View reviewed changes

gongshaotian approved these changes Nov 29, 2024

View reviewed changes

XiaoguangHu01 approved these changes Nov 29, 2024

View reviewed changes

HydrogenSulfate merged commit 54ec035 into PaddlePaddle:develop Nov 29, 2024
28 checks passed

aquagull deleted the svdvals_new_branch branch November 29, 2024 04:56

aquagull mentioned this pull request Dec 4, 2024

飞桨开源社区重磅福利！开源贡献者专享2000元会员礼 PaddlePaddle/community#1015

Open

	self.assertTrue(np.allclose(np_s, r, rtol=1e-6))
	np.testing.assert_allclose(np_s, r, rtol=1e-6))

		@@ -0,0 +1,158 @@
		# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.

	# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.
	# Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved.

【Paddle Tensor No.26】Svdvals new branch #69796

【Paddle Tensor No.26】Svdvals new branch #69796

Uh oh!

Conversation

aquagull commented Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Nov 28, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HydrogenSulfate Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

SigureMo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aquagull commented Nov 28, 2024 •

edited

Loading

HydrogenSulfate Nov 29, 2024 •

edited

Loading