-
Notifications
You must be signed in to change notification settings - Fork 73
iOS Catalog Improvements #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d05878c
Show the settings button in the `ConfiguredPDFViewComponent` iOS example
b64522f
Add README file for the Catalog
fc486d2
Fix issue where the `pageIndex` prop needed to be set before the docu…
def7cb3
Update README
69e2c40
Bump version number to 1.30.18
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
## Catalog | ||
|
||
The project contains a large set of sample code, which illustrates how to set up and customize PSPDFKit for various use cases. You can run the Catalog app on Android and iOS. | ||
|
||
### Running the Catalog on Android | ||
|
||
#### Requirements | ||
|
||
- Android SDK | ||
- Android NDK | ||
- Android Build Tools 23.0.1 (React Native) | ||
- Android Build Tools 28.0.3 (PSPDFKit module) | ||
- Android Gradle plugin 3.4.1 or later. | ||
- PSPDFKit for Android 6.6.0 or later. | ||
- React Native 0.60.4. | ||
|
||
#### Getting Started | ||
|
||
1. Clone the repository. `git clone https://github.com/PSPDFKit/react-native.git`. | ||
2. Install dependencies: run `yarn install` from `samples/Catalog` directory. (Because of a [bug](https://github.com/yarnpkg/yarn/issues/2165) you may need to clean `yarn`'s cache with `yarn cache clean` before.) | ||
3. Update license key in `samples/Catalog/android/app/src/main/AndroidManifest.xml`: | ||
|
||
```xml | ||
<application> | ||
... | ||
|
||
<meta-data | ||
android:name="pspdfkit_license_key" | ||
android:value="YOUR_LICENSE_KEY_GOES_HERE"/> | ||
|
||
</application> | ||
``` | ||
|
||
4. Catalog app is now ready to launch. From `samples/Catalog` directory run `react-native run-android`. | ||
|
||
### Running the Catalog on iOS | ||
|
||
#### Requirements | ||
|
||
- The latest [Xcode](https://developer.apple.com/xcode/). | ||
- the latest version of PSPDFKit for iOS. | ||
- React Native 0.60.4. | ||
|
||
#### Getting Started | ||
|
||
1. Clone the repository: `git clone https://github.com/PSPDFKit/react-native.git`. | ||
2. Step into your newly cloned folder: `cd react-native` and create a new `PSPDFKit` directory: `mkdir PSPDFKit`. | ||
3. [Download the latest version of PSPDFKit for iOS](https://customers.pspdfkit.com/download/binary/ios/latest) and mount the DMG file. | ||
4. Copy `PSPDFKit.xcframework` and `PSPDFKitUI.xcframework` into the `PSPDFKit` directory. | ||
5. Install dependencies: `yarn install` in `samples/Catalog` directory. (Because of a [bug](https://github.com/yarnpkg/yarn/issues/2165) you may need to clean `yarn`'s cache with `yarn cache clean` before.) | ||
6. Run the app with `react-native-cli`: `react-native run-ios` | ||
|
||
**Note:** If you get an error about `config.h` not being found check out [this blog post](https://tuntunir.blogspot.com/2018/02/react-native-fatal-error-configh-file.html) for information on how to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to allow setting this after the document is set.