Add "Native Catalog" with advanced integration examples on iOS #339

radazzouz · 2020-01-10T19:39:20Z

Details

This PR adds the Native Catalog sample project on iOS. The sample project was originally added on Android in #318.

Code that needs to be reviewed (Is not Autogenerated)

App.js.
shared.js.
README.md.
All Objective-C Code.

Acceptance Criteria

When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

radazzouz · 2020-01-15T21:12:58Z

samples/NativeCatalog/App.js

@@ -85,17 +100,23 @@ class ManualSigningScreen extends Component<{}> {
            flexDirection: 'row',
            height: 40,
            alignItems: 'center',
-            padding: 10,
+            padding: -10,


This looked bad on iOS. On Android it looks okay with -10.

I think it would actually look nicer with this (at least on iOS, since the view is auto sized and the text doesn't go outside the safe area. I haven't tested it on Android though.)

<SafeAreaView style={{ flexDirection: 'row', alignItems: 'center', }}>

Do you think we could use that?

Thanks @steviki! In 1223bab I switched to SafeAreaView and it looks great on iOS.

@irgendeinich when you have a minute can you please test the first two examples on Android to see SafeAreaView works correctly? I am no longer able to run the NativeCatalog on Android.

Using SafeAreaView also works great on Android.

Manual Signing Example Watermark Example

irgendeinich

JS changes look good, and Android Catalog is still working as expected.

steviki

This looks good to me! 👍

Just a few small nitpicks.

And sorry for the late review!

samples/NativeCatalog/App.js

samples/NativeCatalog/ios/NativeCatalog/Examples/CustomPdfView.m

steviki · 2020-02-21T17:02:13Z

samples/NativeCatalog/App.js

@@ -85,17 +100,23 @@ class ManualSigningScreen extends Component<{}> {
            flexDirection: 'row',
            height: 40,
            alignItems: 'center',
-            padding: 10,
+            padding: -10,


I think it would actually look nicer with this (at least on iOS, since the view is auto sized and the text doesn't go outside the safe area. I haven't tested it on Android though.)

<SafeAreaView style={{ flexDirection: 'row', alignItems: 'center', }}>

Do you think we could use that?

steviki · 2020-02-21T17:03:14Z

samples/NativeCatalog/ios/NativeCatalog/Examples/CustomPdfView.m

+      signer.reason = @"Contract agreement";
+      PSPDFSignatureManager *signatureManager = PSPDFKitGlobal.sharedInstance.signatureManager;
+      [signatureManager clearRegisteredSigners];
+      [signatureManager registerSigner:signer];


We don't actually need to register the signer, since we use it directly to sign the form element, instead of using the signature view.

This reverts commit 9dc11b3.

Co-Authored-By: Stefan Kieleithner <[email protected]>

radazzouz added enhancement iOS HOLD labels Jan 10, 2020

radazzouz self-assigned this Jan 13, 2020

radazzouz force-pushed the rad/native-catalog branch from 0cffb6e to 2abe3b6 Compare January 15, 2020 21:22

radazzouz commented Jan 15, 2020

View reviewed changes

radazzouz requested review from irgendeinich and steviki January 15, 2020 21:23

radazzouz added READY TO REVIEW and removed HOLD labels Jan 15, 2020

irgendeinich approved these changes Jan 16, 2020

View reviewed changes

radazzouz force-pushed the rad/native-catalog branch from 2abe3b6 to a8e9a9f Compare January 28, 2020 15:49

radazzouz force-pushed the rad/native-catalog branch from a8e9a9f to 3f2cddb Compare February 4, 2020 17:43

radazzouz force-pushed the rad/native-catalog branch 2 times, most recently from 03eb62f to 0db4612 Compare February 19, 2020 12:36

steviki approved these changes Feb 21, 2020

View reviewed changes

Rad Azzouz added 11 commits March 16, 2020 14:04

Revert "Remove iOS project"

dfbe2e8

This reverts commit 9dc11b3.

Add iOS "Native Catalog" with advanced integration examples

bc33dae

Delete duplicate certificate which caused Android to fail

671c9bd

Fix all examples

6266791

Update README

02011ae

Run prettier

db42da0

Fix localization warning in the Xcode project

b5ef631

💄

d56d27e

Remove tvOS files

a8202cc

Update copyright comments

71a0f94

Update project

c4f692e

radazzouz force-pushed the rad/native-catalog branch from b59658a to c4f692e Compare March 16, 2020 18:04

radazzouz and others added 2 commits March 16, 2020 14:50

Apply suggestions from code review

68cf43d

Co-Authored-By: Stefan Kieleithner <[email protected]>

Do not register the signer

7d06e62

Rad Azzouz and others added 3 commits March 16, 2020 15:12

Use SafeAreaView

1223bab

Update CustomPdfViewManager to work with new PdfUiFragment API

78aa73f

Update README

c312b0f

radazzouz force-pushed the rad/native-catalog branch from 2596ae7 to c312b0f Compare March 18, 2020 11:43

Rad Azzouz added 2 commits March 18, 2020 07:51

Update the example README

b42ffe5

Bump version to 1.28.4

21f474b

radazzouz merged commit 628f5dc into master Mar 18, 2020

radazzouz deleted the rad/native-catalog branch March 18, 2020 11:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add "Native Catalog" with advanced integration examples on iOS #339

Add "Native Catalog" with advanced integration examples on iOS #339

Uh oh!

radazzouz commented Jan 10, 2020 •

edited

Loading

Uh oh!

radazzouz Jan 15, 2020

Uh oh!

steviki Feb 21, 2020

Uh oh!

radazzouz Mar 16, 2020 •

edited

Loading

Uh oh!

radazzouz Mar 18, 2020

Uh oh!

irgendeinich left a comment

Uh oh!

steviki left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steviki Feb 21, 2020

Uh oh!

steviki Feb 21, 2020

Uh oh!

Uh oh!

Add "Native Catalog" with advanced integration examples on iOS #339

Add "Native Catalog" with advanced integration examples on iOS #339

Uh oh!

Conversation

radazzouz commented Jan 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Code that needs to be reviewed (Is not Autogenerated)

Acceptance Criteria

Uh oh!

radazzouz Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

steviki Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

radazzouz Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

radazzouz Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

irgendeinich left a comment

Choose a reason for hiding this comment

Uh oh!

steviki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steviki Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

steviki Feb 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

radazzouz commented Jan 10, 2020 •

edited

Loading

radazzouz Mar 16, 2020 •

edited

Loading