Skip to content

Fix enableAnnotationEditing on iOS #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

Fix enableAnnotationEditing on iOS #310

merged 1 commit into from
Oct 16, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Oct 15, 2019 •
edited
Loading

Details

When enableAnnotationEditing is set to false, we internally set editableAnnotationTypes to nil. The condition was wrong! 🤦‍♂

Acceptance Criteria

@radazzouz radazzouz requested a review from steviki October 15, 2019 15:33
@radazzouz radazzouz self-assigned this Oct 15, 2019
steipete
steipete approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@radazzouz radazzouz merged commit d7c1af4 into master Oct 16, 2019
@radazzouz radazzouz deleted the rad/fix-enableAnnotationEditing-ios branch October 16, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steipete steipete steipete approved these changes

@steviki steviki steviki approved these changes

Assignees

@radazzouz radazzouz

Labels
iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radazzouz @steipete @steviki