Skip to content

Add toolbarTitle Javascript API to override the iOS toolbar title #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jul 15, 2019

Solves #253


Details

Adds toolbarTitle Javascript API to override the iOS toolbar title. See ConfiguredPDFViewComponent example from Catalog.ios.js.

Screen Shot 2019-07-15 at 11 38 40 AM

Note: This requires to set showDocumentLabel, useParentNavigationBar, and allowToolbarTitleChange to false in your Configuration before setting the custom title.

Usage:

<PSPDFKitView
  document={"PDFs/Annual Report.pdf"}
  configuration={{
    showDocumentLabel: false,
    useParentNavigationBar: false,
    allowToolbarTitleChange: false
  }}
  toolbarTitle={"Custom Title"}
/>

Acceptance Criteria

  • This API is iOS-only. It doesn't impact Android.
  • This API is iOS-only. It doesn't impact UWP.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Copy link
Contributor

@irgendeinich irgendeinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't affect Android

Copy link
Contributor

@nickwinder nickwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes touch windows. 👍

@radazzouz radazzouz force-pushed the rad/toolbarTitle-ios branch from 9b50638 to ee45d16 Compare July 16, 2019 15:03
@radazzouz radazzouz merged commit 610e292 into master Jul 16, 2019
@radazzouz radazzouz deleted the rad/toolbarTitle-ios branch July 16, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants