Skip to content

Adds Javascript API to customize the toolbar on iOS #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 12, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented May 29, 2019

Fixes #204


Details

Adds Javascript API to customize the tool bar on iOS.

recording

Acceptance Criteria

@radazzouz radazzouz force-pushed the rad/customize-toolbar-ios branch from d81ca8f to 0ad2b37 Compare June 10, 2019 16:01
@radazzouz radazzouz force-pushed the rad/customize-toolbar-ios branch from dc4c74e to e9f659e Compare June 10, 2019 16:07
@radazzouz radazzouz changed the title [WIP] Adds Javascript API to customize the tool bar on iOS Adds Javascript API to customize the tool bar on iOS Jun 10, 2019
@radazzouz radazzouz requested a review from steviki June 10, 2019 16:08
radazzouz and others added 11 commits June 11, 2019 06:36
Co-Authored-By: Stefan Kieleithner <[email protected]>
Co-Authored-By: Stefan Kieleithner <[email protected]>
Co-Authored-By: Stefan Kieleithner <[email protected]>
Co-Authored-By: Stefan Kieleithner <[email protected]>
Co-Authored-By: Stefan Kieleithner <[email protected]>
Co-Authored-By: Stefan Kieleithner <[email protected]>
Co-Authored-By: Stefan Kieleithner <[email protected]>
Co-Authored-By: Stefan Kieleithner <[email protected]>
@radazzouz radazzouz requested a review from steviki June 11, 2019 19:21
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@nickwinder nickwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not affect windows. LGTM

@radazzouz radazzouz changed the title Adds Javascript API to customize the tool bar on iOS Adds Javascript API to customize the toolbar on iOS Jun 12, 2019
@radazzouz radazzouz merged commit accdd0b into master Jun 12, 2019
@radazzouz radazzouz deleted the rad/customize-toolbar-ios branch June 12, 2019 12:47
radazzouz pushed a commit that referenced this pull request Jun 12, 2019
We can now do it from JavaScript (See #233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IOS] Adjusting the sharingOptions
4 participants