Skip to content

Align annotations changed with ios #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2019
Merged

Align annotations changed with ios #224

merged 2 commits into from
May 21, 2019

Conversation

nickwinder
Copy link
Contributor

@nickwinder nickwinder commented May 21, 2019 •
edited
Loading

Fixes : https://github.com/PSPDFKit/react-native/issues/196

Details

This PR changes annotation events on UWP to pass back a list of annotations like Android and iOS does.

Acceptance Criteria

@nickwinder nickwinder requested a review from phraemer May 21, 2019 15:49
@nickwinder nickwinder self-assigned this May 21, 2019
steipete
steipete approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nickwinder nickwinder merged commit 557898d into master May 21, 2019
@nickwinder nickwinder deleted the nick/uwp/align-annotations-changed-with-ios branch May 21, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steipete steipete steipete approved these changes

@phraemer phraemer Awaiting requested review from phraemer

Assignees

@nickwinder nickwinder

Labels
windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Api of onAnnotationsChanged is inconsistent
2 participants
@nickwinder @steipete