Skip to content

UWP: Remove Annotation #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2019
Merged

UWP: Remove Annotation #222

merged 3 commits into from
May 20, 2019

Conversation

nickwinder
Copy link
Contributor

@nickwinder nickwinder commented May 17, 2019

Fixes : https://github.com/PSPDFKit/react-native/issues/216

Details

Brings removeAnnotation API inline with iOS and Android.

Also fixes small typo with getAnnotations JSON reply.

Acceptance Criteria

@nickwinder nickwinder self-assigned this May 17, 2019
Copy link
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@phraemer phraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickwinder nickwinder merged commit 590f30a into master May 20, 2019
@nickwinder nickwinder deleted the nick/uwp/remove-annotation branch May 20, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement removeAnnotation
3 participants